Fix _compare_lists treating 1 and True as equal in JSON diff#181
Draft
Copilot wants to merge 2 commits into
Draft
Fix _compare_lists treating 1 and True as equal in JSON diff#181Copilot wants to merge 2 commits into
_compare_lists treating 1 and True as equal in JSON diff#181Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix jsondiff to correctly handle list item equality comparison
Fix Jun 18, 2026
_compare_lists treating 1 and True as equal in JSON diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffBuilder._compare_listsused Python's==to skip unchanged list items, but1 == Truein Python causes the diff to miss type changes that are meaningful in JSON.Changes
jsonpatch.py: Replaceif old == new: continuewithelif self.dumps(old) == self.dumps(new): continue, placed after theisinstancechecks forMutableMapping/MutableSequence. This mirrors the existing logic in_compare_values, which already had a comment explaining whydumps-based comparison is necessary.tests.py: Addtest_issue180covering the case where a list contains1vsTrueitems.Example